--- a/lib/Nagios/Check/DNS/check_tlsa_record.pm Mon May 30 22:51:07 2016 +0200
+++ b/lib/Nagios/Check/DNS/check_tlsa_record.pm Tue May 31 16:35:56 2016 +0200
@@ -1,20 +1,21 @@
+package Nagios::Check::DNS::check_tlsa_record;
+
use strict;
use warnings;
use feature qw(say switch);
+use if $ENV{DEBUG} => 'Smart::Comments';
#use if $^V >= v5.0.20 => (experimental => gw(smartmatch));
use experimental qw(smartmatch);
use File::Temp;
-package Nagios::Check::DNS::check_tlsa_record;
-
-$Nagios::Check::DNS::check_tlsa_record::VERSION = '0.1';
+our $VERSION = '0.1';
#@TODO use only fh of tempfile instead of filename
my $tempfile = File::Temp->new(
TEMPLATE => '._tlsaXXXX',
DIR => '/tmp/',
- SUFFIX => '.tmp'
+ SUFFIX => '.tmp',
);
sub main {
@@ -22,7 +23,7 @@
my $port = shift || 443;
my $protocol = shift || 'tcp';
my $validate = validate_tsla($domain, $port, $protocol);
- return "$validate";
+ return $validate;
}
sub dig_tlsa {
@@ -75,7 +76,7 @@
my $check_expiry = "openssl x509 -in $cert -noout -startdate -enddate";
my $expiry = qx($check_expiry);
- return "$expiry";
+ return $expiry;
}
sub get_tlsa_match_type {
@@ -91,7 +92,7 @@
when ('2') { $hashit = 'sha512' }
default { $hashit = 'sha256' }
}
- return "$hashit";
+ return $hashit;
}
sub get_dig_tlsa_record {
@@ -99,21 +100,21 @@
my $dig_tlsa = substr($dig_return, 6,);
$dig_tlsa =~ s/(\S*)\s+(\S*)$/$1$2/;
- return "$dig_tlsa";
+ return $dig_tlsa;
}
sub get_tlsa_usage {
my $dig_return = shift;
my $tlsa_usage = substr($dig_return, 0, 1);
- return "$tlsa_usage";
+ return $tlsa_usage;
}
sub get_tlsa_selector {
my $dig_return = shift;
my $tlsa_selector = substr($dig_return, 2, 1);
- return "$tlsa_selector";
+ return $tlsa_selector;
}
sub validate_tsla {
--- a/t/check_tlsa_record.t Mon May 30 22:51:07 2016 +0200
+++ b/t/check_tlsa_record.t Tue May 31 16:35:56 2016 +0200
@@ -4,9 +4,7 @@
use warnings;
use Test::More qw(no_plan);
-BEGIN { use_ok('Nagios::Check::DNS::check_tlsa_record') };
-
-require_ok('Nagios::Check::DNS::check_tlsa_record');
+BEGIN { use_ok 'Nagios::Check::DNS::check_tlsa_record' };
#@TODO write tests
#my $return = Nagios::Check::DNS::check_tlsa_record::main(($domain, $port));